MBTI-PDF-SNAPSHOT-SYNC-GUARD-H1: add PDF snapshot render-source cache guard#2579
Merged
Merged
Conversation
fermatmind
force-pushed
the
codex/mbti-pdf-snapshot-sync-guard-h1
branch
from
358c47a to
d00b590
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
X-Pdf-Print-Asset-Hashto MBTI result-page PDF success/failure responses and CORS expose headers.GOTENBERG_RESULT_PRINT_ASSET_HASH, while keepingMBTI_RESULT_PAGE_SNAPSHOT_RENDER_VERSIONas the manual fallback escape hatch.Why
When fap-web print-impact files change, backend PDF artifacts need a render-source dimension beyond content/surface/engine/renderVersion so old cached PDFs do not mask frontend snapshot changes.
Validation
php artisan test --filter=AttemptPublicReportPdfParityTest./vendor/bin/pint --dirtyruby -e "require 'yaml'; YAML.load_file('docs/codex/pr-train.yaml')"\n-python3 -m json.tool docs/codex/pr-train-state.json >/dev/null\n-git diff --check\n\n## Deferred\n- No Gotenberg route/timeout changes.\n- No content injection, content asset, visual layout, CMS/DB, import, production cache clear, deploy, sitemap/llms/SEO runtime, or mPDF behavior change.\n- H2 will strengthen the operator rendered PDF smoke gate.\n\n## Repository Rule Impact\nNo content authority change. This is backend PDF artifact/cache observability and tests only.