MBTI-PDF-RESULT-SNAPSHOT-SHELL: remove runtime pollutants from MBTI print snapshot shell#1504
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcc689f89e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "MBTI-PDF-RESULT-SNAPSHOT-CONTENT-06" | ||
| ], | ||
| "status": "committed", | ||
| "commit_sha": "60914c25148a6f41088466dfcc904c827d6f05c4", |
There was a problem hiding this comment.
Record the reviewed head SHA in the train state
For this PR-train entry the state is marked committed, but the recorded commit_sha still points at 60914c25148a6f41088466dfcc904c827d6f05c4 while the commit under review is 17e7cedebf80d6c04397fa4b01136cffc21eb251. Any train reconciliation or dependency check that trusts this field will verify/report the wrong revision after this commit is pushed or squashed, so the ledger should be updated to the actual head SHA.
Useful? React with 👍 / 👎.
What changed
proxy.tsfor/result/{id}/print?surface=mbti.result_page_snapshot.v3.SiteChrome, header, footer, andCookieBannerwhile preserving providers/locale/font/runtime wrappers.MbtiDesktopCloneShellsnapshot mode to remove the sticky rail, ON THIS PAGE/TOOLS, final offers, checkout/unlock flows, share/retest/history/PDF/order/workspace actions, supplementary CTAs, recommended reads, and trailing footer-like nodes.Why
PR-A established the v3 route/surface fail-closed contract and PR-B injected real desktop clone content. This PR-C removes ordinary web runtime pollutants from the v3
/printsnapshot shell so content-ready pages are not blocked by header/cookie/footer/sidebar/tools/commerce UI.Explicit contract answers
mbti.result_page_snapshot.v3/printuses an internal header-driven PDF snapshot shell.snapshotMode.snapshotMode./result/{id}pages: unchanged; the snapshot shell header is only set for v3/print.Validation
pnpm exec vitest run tests/contracts/result-private-print-chrome.contract.test.ts tests/contracts/result-gotenberg-print-route.contract.test.ts tests/contracts/result-client-view-state.contract.test.tsx tests/contracts/mbti-desktop-shell-cta.contract.test.tsx-> pass, 4 files / 54 testspnpm test:contract-> pass, 603 files / 3559 testspnpm typecheck-> passNEXT_PUBLIC_API_URL=https://api.fermatmind.com pnpm build-> passruby -e "require 'yaml'; YAML.load_file('docs/codex/pr-train.yaml'); puts 'yaml ok'"-> passpython3 -m json.tool docs/codex/pr-train-state.json >/dev/null-> passgit diff --check-> passIntentionally deferred
Repository rule impact
This is frontend product-code rendering/shell behavior for the private MBTI result print snapshot. It does not change CMS/content authority, SEO enumeration, public editorial content, sitemap authority, or backend-owned content surfaces.