Skip to content

MBTI64-ZH32-EN32-V8_5-V5-FIRST-CLASS-SECTIONS-UI-ORDER-REPAIR-01#1509

Merged
fermatmind merged 1 commit into
mainfrom
codex/mbti64-v85-v5-first-class-sections-ui-order-repair-01
Jul 1, 2026
Merged

MBTI64-ZH32-EN32-V8_5-V5-FIRST-CLASS-SECTIONS-UI-ORDER-REPAIR-01#1509
fermatmind merged 1 commit into
mainfrom
codex/mbti64-v85-v5-first-class-sections-ui-order-repair-01

Conversation

@fermatmind

Copy link
Copy Markdown
Owner

What changed

  • Recognize MBTI64 V8.5/V5 v8_5_* first-class CMS sections in the personality detail renderer.
  • Partition V8.5 sections from legacy supplemental sections so the V8.5 reading path renders before legacy projection/supplemental content.
  • Update local/sticky navigation to prioritize V8.5 anchors when those sections are present.
  • Keep old legacy sections as compatibility content after the V8.5 primary path.
  • Add focused contract coverage for V8.5 section rendering and partitioning.

Why

Production backend now exposes V8.5/V5 first-class sections, but the fap-web personality detail page still prioritized the legacy section map and legacy sections. This PR makes the already-promoted CMS content the main reading experience without adding frontend editorial fallback.

Validation

  • pnpm exec vitest run tests/contracts/personality-sections.contract.test.tsx tests/contracts/personality-cms.contract.test.ts
  • pnpm test:contract
  • pnpm typecheck
  • NEXT_PUBLIC_API_URL=https://api.fermatmind.com NEXT_PUBLIC_SITE_URL=https://fermatmind.com pnpm build
  • git diff --check
  • Local production-server smoke against https://api.fermatmind.com for /zh/personality/intj-a and /en/personality/intj-a
  • Playwright screenshot smoke for desktop/mobile zh/en INTJ-A

Intentionally deferred

  • No backend change.
  • No CMS write, approval queue write, promotion, publish, index/search, sitemap/llms mutation, URL Truth write, or production deploy.
  • Staging/production deployment remains handled asynchronously by GitHub Actions and later explicit deployment gates.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e29c68389a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +918 to +920
const intentLinks = hasV85Sections
? buildV85PersonalitySectionShortcuts(locale, v85Sections, mbtiIntentCtaHref)
: legacyIntentLinks;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve section nav when V8.5 links are empty

When the backend returns only V8.5 sections outside the seven hard-coded shortcut keys (for example the v8_5_module_01_* sections that this commit also marks renderable), hasV85Sections becomes true here, so this branch discards legacyIntentLinks; buildV85PersonalitySectionShortcuts then filters all anchors out and returns only the test CTA. On those pages both the hero map and sticky nav lose all content section links even though renderable sections exist, so fall back to legacy links or include the module keys when the V8.5 shortcut list has no anchors.

Useful? React with 👍 / 👎.

@fermatmind fermatmind merged commit fbcc988 into main Jul 1, 2026
6 checks passed
@fermatmind fermatmind deleted the codex/mbti64-v85-v5-first-class-sections-ui-order-repair-01 branch July 1, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant