MBTI-PDF-SNAPSHOT-PRINT-LAYOUT-POLISH-10: polish MBTI snapshot print layout#1511
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b36b6b8d26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "MBTI-PDF-RESULT-SNAPSHOT-VISUAL-PAGINATION" | ||
| ], | ||
| "status": "in_progress", | ||
| "commit_sha": "d336ef462a707e33016f34d85145d15576016d5b", |
There was a problem hiding this comment.
Record the actual reviewed commit SHA
This ledger entry records d336ef... as the fap-web commit, but the commit being reviewed is f13e0e3a994726b5f3adafab3116898a3cb8ba18 and git cat-file -e d336ef... does not resolve in this repository. Any PR-train closeout/reconciliation that trusts this field will look for the wrong revision, so update the ledger to the actual commit SHA before relying on it for merge or cleanup state.
Useful? React with 👍 / 👎.
Summary
Why
PR-F restored the real result-page component tree and current PDFs are HeadlessChrome/Skia, not mPDF or the old summary shell. The remaining issue is print layout: Page 3/Page 7 section openers leave large blank areas because decorative media and large avoid-break cards consume/force page space.
Companion backend PR
Validation
Note: pnpm typecheck was blocked before running by local approve-builds state for esbuild/sharp/unrs-resolver. package.json typecheck is tsc --noEmit, and that exact payload passed directly. I did not take ownership of the unrelated untracked pnpm-workspace.yaml.
Deferred