fix(ci): scope hashFiles glob in cached-seed to avoid timeout#15022
Closed
davidkonigsberg wants to merge 1 commit intomainfrom
Closed
fix(ci): scope hashFiles glob in cached-seed to avoid timeout#15022davidkonigsberg wants to merge 1 commit intomainfrom
davidkonigsberg wants to merge 1 commit intomainfrom
Conversation
The hashFiles('**/Dockerfile*') glob was scanning the entire workspace
including the massive seed/ output directory, causing it to exceed the
120-second timeout. Scoped the glob to only generators/, docker/, and
packages/ where Dockerfiles actually exist.
Co-Authored-By: David Konigsberg <davidakonigsberg@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
davidkonigsberg
deleted the
devin/1776257269-fix-cached-seed-hashfiles-timeout
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a consistent CI failure where the
hashFiles('**/Dockerfile*')call in thecached-seedaction times out after 120 seconds during the post-job cache save step.Error:
hashFiles('**/Dockerfile*') couldn't finish within 120 seconds.Changes Made
hashFilesglob from**/Dockerfile*(entire workspace) togenerators/**/Dockerfile*,docker/**/Dockerfile*,packages/**/Dockerfile*(only directories containing Dockerfiles)Root cause: The
**glob scans the entire workspace, including theseed/output directory which grows to 900MB+ with hundreds of thousands of generated files during seed tests. This causeshashFilesto exceed its 120-second timeout.Testing
cached-seedaction successfullygenerators/,docker/, orpackages/— no Dockerfiles are missed by the scoped globsReview Checklist
find— they do)Link to Devin session: https://app.devin.ai/sessions/48ea5e97c4284bdcbd4b66a2b6accb3b
Requested by: @davidkonigsberg