Coins impl. using sorted dictionary#418
Merged
Merged
Conversation
Unfinished: Unit tests need adjustments/rework.
pbukva
changed the title
This changes prevents issues arising from stroing and returning Coin instance by-reference, which creates potential for modifying the Coin.amount value from an external scope (from outside of the Coins class control).
|
Visit the preview URL for this PR (updated for commit 4ba3d4c): https://fetch-docs-preview--pr418-feat-coins-rework-us-u8m7vj9q.web.app (expires Sat, 07 Jun 2025 13:45:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2de39fd4e81249941960b74fbab0a62d90d69f8 |
pbukva
commented
Jun 3, 2025
pbukva
commented
Jun 3, 2025
…onary' into feat/coins_rework_using_sorted_dictionary
pbukva
changed the title
pbukva
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfinished: Unit tests need adjustments/rework.
Proposed Changes
[describe the changes here...]
Linked Issues
[if applicable, add links to issues resolved by this PR]
Types of changes
What type of change does this pull request make (put an
xin the boxes that apply)?Checklist
Put an
xin the boxes that apply:If applicable
Further comments
[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]