This repository was archived by the owner on Jul 16, 2024. It is now read-only.
Open
Conversation
5A11
reviewed
Jun 7, 2023
Comment on lines
-5
to
-7
| <a href="/fund_form" class="announcement-link"> | ||
| >> Apply for the $150M Developer Fund << | ||
| </a> |
Contributor
There was a problem hiding this comment.
Just remove this part. Leave the other parts in case we want to add an announcement in the future.
Contributor
Author
There was a problem hiding this comment.
@5A11 I have updated the pull request as suggested. Can you please take a look at the new changes?
Contributor
There was a problem hiding this comment.
Just remove linens 5 to 7 and keep the other lines.
Contributor
Author
There was a problem hiding this comment.
{% block announce %}
.... ....
{% endblock %}
The above block is just used to show line 5-7. If we remove line 5-7, then that code snippet does nothing. Do we still need to keep it?
5A11
reviewed
Jun 7, 2023
Contributor
5A11
left a comment
5A11
left a comment
There was a problem hiding this comment.
Just 1 comment. Also address the merge conflict and it's lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close https://github.com/fetchai/ecosystem-tasks/issues/266