fix: resolve calculator RCE vulnerability and improve devcontainer reliability#160
Open
Chitranshu0 wants to merge 2 commits into
Open
fix: resolve calculator RCE vulnerability and improve devcontainer reliability#160Chitranshu0 wants to merge 2 commits into
Chitranshu0 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Issue #5 by removing an unsafe
eval()usage in the Trip Planner calculator tool and improving the reliability of the Internet Computer devcontainer setup script.Security Improvements
eval()with a safe AST-based evaluatorTrueandFalse)Devcontainer Improvements
git,node,npm,dfx)set -euo pipefailType of Change
Checklist
contributors/<agent-name>/(not applicable)ruff check .ruff format .README.mdfor changed example(s) (not required).env.exampleif environment variables are required (not required)contributors/CHANGELOG.mdorCHANGELOG.md(only if maintainers require it)Related Issue
Closes #5
Notes for Reviewers
Calculator Tool
eval()execution with a restricted AST-based evaluator.Security Validation
The following payload categories were tested and rejected:
__import__compileexecopenglobalslocalsTest Results
Files Changed
Crewai-agents/trip_planner/tools/calculator_tools.pyCrewai-agents/trip_planner/tests/test_calculator_safety.pyweb3/internet-computer/scripts/devcontainer-setup.sh