Make the HTTP request-head size limit configurable - #953
Merged
fewensa merged 1 commit intoSep 11, 2026
Conversation
codeon:
version: 1
authority: FWN-365
description: |-
Expose HttpServer::with_max_request_head_bytes with a 64 KiB default and reject zero before serving. Thread the configured limit through HTTP/1 request-head parsing and h2c upgrade handoff so both paths share one authority. Document the setter in README.md and crates/rttp/README.md, and add below-limit, exact-limit, oversized, malformed, and body-limit independence tests on both paths.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fewensa
deleted the
codeon/fewensa/FWN-365/a2-0dead31f35bc4f319b809a4513d468b2
branch
September 11, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
HttpServer::with_max_request_head_byteswith a 64 KiB default and reject zero before serving. Thread the configured limit through HTTP/1 request-head parsing and h2c upgrade handoff so both paths share one authority.Document the setter in
README.mdandcrates/rttp/README.md. Add below-limit, exact-limit, oversized, malformed, and body-limit independence tests on both paths.Verified with
cargo test -p rttp-serverandcargo test -p rttp --test test_server --test http2_feature --features http2.