Export SaveData through RTTP facades - #955
Closed
fewensa wants to merge 2 commits into
Closed
Conversation
codeon:
version: 1
authority: FWN-375
description: |-
Export SaveData and SaveDataParseError through rttp_client and the client-enabled rttp facade.
Add focused metadata facade assertions covering SaveData::parse("on") success and SaveData::parse("?1") failure through both public facade paths.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
codeon:
version: 1
authority: FWN-375
description: |-
Apply repository rustfmt ordering and wrapping to the SaveData facade exports and metadata facade test imports.
This resolves the sealed rustfmt validation finding without changing behavior.
fewensa
deleted the
codeon/fewensa/FWN-375/a1-11fa9703532943598af7ccb0b6be5727
branch
September 13, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export SaveData and SaveDataParseError from rttp_client and the client-enabled rttp facade. Add metadata facade coverage for SaveData::parse("on") success and SaveData::parse("?1") failure. Verification passed: cargo test -p rttp_client --test metadata_facade --all-features; cargo test -p rttp --test metadata_facade --all-features.