Skip to content

Harden typed Content-Range parsing - #956

Merged
fewensa merged 1 commit into
mainfrom
codeon/fewensa/FWN-335/a1-2b6809684d1542e1b2f3784d6c91aeae
Sep 12, 2026
Merged

Harden typed Content-Range parsing#956
fewensa merged 1 commit into
mainfrom
codeon/fewensa/FWN-335/a1-2b6809684d1542e1b2f3784d6c91aeae

Conversation

@fewensa

@fewensa fewensa commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Harden Content-Range parsing to trim HTTP OWS, reject invalid controls, separators, bounds, overflow, and duplicates, and keep canonical bytes formatting.
  • Add focused protocol tests for satisfied, unknown-length, unsatisfied, canonical, and malformed Content-Range values.
  • Document typed Content-Range behavior in the root and server READMEs.

Verification

  • cargo fmt --check
  • cargo test -p rttp-protocol range
  • cargo test -p rttp_client test_response
  • cargo test -p rttp-server metadata_facade --test metadata_facade
  • cargo test -p rttp --test test_server_models content_range
  • cargo test -p rttp --test metadata_facade
  • cargo test -p rttp-workspace-tests sync_client_typed_all_unsatisfiable_ranges_map_to_server_416_response

codeon:
  version: 1
  authority: FWN-335
  description: |-
    Validate Content-Range with HTTP OWS-aware singleton parsing, preserving canonical formatting while rejecting malformed separators, invalid bounds, controls, overflow, and duplicate fields.
    
    Add focused protocol tests for canonical byte and unsatisfied forms, and update user-facing range metadata documentation for the client/server facade behavior.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T11:00:35.153963Z 1535f86 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fewensa
fewensa merged commit 20f3da9 into main Sep 12, 2026
1 check passed
@fewensa
fewensa deleted the codeon/fewensa/FWN-335/a1-2b6809684d1542e1b2f3784d6c91aeae branch September 12, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant