Skip to content

Add typed DPR request Client Hint metadata - #958

Merged
fewensa merged 1 commit into
mainfrom
codeon/fewensa/FWN-342/a1-64ffb95525cc4c4abfb7c8a9f6f8594d
Sep 13, 2026
Merged

Add typed DPR request Client Hint metadata#958
fewensa merged 1 commit into
mainfrom
codeon/fewensa/FWN-342/a1-64ffb95525cc4c4abfb7c8a9f6f8594d

Conversation

@fewensa

@fewensa fewensa commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add bounded singleton DPR request Client Hint parsing with finite positive decimal validation and raw header preservation.
  • Expose typed DPR metadata through client, server, and rttp facades, including an opt-in HttpClient::dpr setter.
  • Add focused protocol, facade, raw request, and HTTP/1.1 matrix coverage plus metadata-only docs.

Verification

  • cargo test -p rttp-protocol --test client_hints
  • cargo test -p rttp_client --test metadata_facade
  • cargo test -p rttp-workspace-tests --test metadata_http11_interoperability_matrix
  • cargo test -p rttp-server --test metadata_facade
  • cargo test -p rttp_client --test test_raw_request_capture dpr
  • cargo fmt --all -- --check
  • git diff --check

codeon:
  version: 1
  authority: FWN-342
  description: |-
    Implement bounded singleton DPR request Client Hint metadata across the protocol, client, server, and facade APIs. Add strict finite-positive decimal parsing with raw-header preservation, validated client emission, focused protocol/facade/HTTP/1.1 tests, and metadata-only documentation that excludes negotiation and automatic Client Hint emission.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T02:46:36.419746Z 7f0fd83 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fewensa
fewensa merged commit c7c905d into main Sep 13, 2026
1 check passed
@fewensa
fewensa deleted the codeon/fewensa/FWN-342/a1-64ffb95525cc4c4abfb7c8a9f6f8594d branch September 13, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant