Add typed X-Download-Options response metadata - #959
Open
fewensa wants to merge 1 commit into
Open
Conversation
codeon:
version: 1
authority: FWN-343
description: |-
Add a bounded singleton parser for X-Download-Options so RTTP can expose noopen as typed response metadata without changing download handling policy.
Parse the field case-insensitively, trim optional whitespace, reject empty, duplicate, unknown, oversized, and control-byte values, and emit canonical noopen. Wire client and server accessors plus facade re-exports, preserve raw headers, and cover valid, malformed, and roundtrip cases in protocol, client, server, and facade tests.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bounded singleton X-Download-Options response metadata for RTTP.
Parse the noopen directive case-insensitively, trim optional whitespace, reject empty, duplicate, unknown, oversized, and control-byte values, and emit canonical noopen. Expose client and server accessors plus facade re-exports, preserve raw headers, and keep download handling policy unchanged.
Cover valid, malformed, duplicate, empty, unknown, oversized, control-byte, raw-preservation, and roundtrip cases in protocol, client, server, and facade tests, and document the metadata-only parser beside the other X-* singleton headers.