Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 79.00% 82.51% +3.50%
==========================================
Files 28 32 +4
Lines 3148 3482 +334
==========================================
+ Hits 2487 2873 +386
+ Misses 661 609 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds constant temperature heat equation basis. Currently the basis is called
Temperature, but probably there are better names. It's scalar, but currently it just mimics this using a poloidal and toroidal basis and only having a toroidal component. Ideally, Limace.jl separates into aScalarBasis <: Basisand aVectorBasis <: Basisand build everything on that.Tests include calculations of critical Rayleigh numbers, comparing to published results from the
SINGEandkorecodes. Documentation is not there yet and it would be desirable to have some interface for the search of critical parameters in Limace.jl (not just in the tests).