fix: add missing function to support howmany parameter with CUDA - #17
Open
svalat wants to merge 3 commits into
Open
fix: add missing function to support howmany parameter with CUDA#17svalat wants to merge 3 commits into
svalat wants to merge 3 commits into
Conversation
…ny feature of SHTns
…ect about howmany parameter
|
You use both "sizef" and "size", I think "sizef" are typos, no? |
Author
|
@nschaeff Good catch, this was a typo => fixed. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 49.12% 43.73% -5.39%
==========================================
Files 9 9
Lines 458 503 +45
==========================================
- Hits 225 220 -5
- Misses 233 283 +50 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some missing functions when wanting to use SHTns.jl with CUDA and parameter
hownmany > 1.It just extends what was already done for the CPU part applying it with CUDA types.