Skip to content

feat!: Move to @fgiova/sqs-consumer#3

Merged
fgiova merged 1 commit into
mainfrom
feat/use-fgiova-sqs-client
Sep 3, 2025
Merged

feat!: Move to @fgiova/sqs-consumer#3
fgiova merged 1 commit into
mainfrom
feat/use-fgiova-sqs-client

Conversation

@fgiova
Copy link
Copy Markdown
Owner

@fgiova fgiova commented Sep 3, 2025

BREAKING-CHANGE: some changes according to @fgiova/sqs-consumer synth

BREAKING-CHANGE: some changes according to @fgiova/sqs-consumer synth
Copilot AI review requested due to automatic review settings September 3, 2025 14:43
@fgiova fgiova merged commit 62b8657 into main Sep 3, 2025
7 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the plugin from the legacy sqs-consumer library to @fgiova/sqs-consumer, updating the underlying SQS consumer implementation and modernizing the codebase. The changes include updating test infrastructure from ElasticMQ to LocalStack, migrating from ESLint to Biome for linting, and updating the minimum Fastify version requirement from 4.x to 5.x.

Key changes:

  • Replace sqs-consumer dependency with @fgiova/sqs-consumer and update the plugin API accordingly
  • Migrate test infrastructure from ElasticMQ to LocalStack for better AWS compatibility
  • Switch from ESLint to Biome for code formatting and linting

Reviewed Changes

Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/index.ts Core plugin implementation updated to use new SQS consumer library with modified API structure
package.json Dependencies updated to use new SQS consumer library, build tools, and linting setup
test/unit/index.ts Test suite updated for new API structure and LocalStack integration
test/scripts/runners/localstack.js New LocalStack container setup replacing ElasticMQ
test/helpers/sqsMessage.ts Helper functions updated for LocalStack endpoint configuration
biome.json New Biome configuration file
README.md Documentation updated to reflect new API and requirements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +36 to +37
// biome-ignore lint/correctness/noUnusedVariables: leave for clarity
container: localStackContainer,
Copy link

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The localStackContainer variable is marked as unused but kept for clarity. Consider either using it for proper cleanup or removing it entirely to avoid confusion.

Suggested change
// biome-ignore lint/correctness/noUnusedVariables: leave for clarity
container: localStackContainer,

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants