Skip to content

feat: update dependencies#5

Merged
fgiova merged 1 commit into
mainfrom
feat/update-dependencies
Sep 2, 2025
Merged

feat: update dependencies#5
fgiova merged 1 commit into
mainfrom
feat/update-dependencies

Conversation

@fgiova
Copy link
Copy Markdown
Owner

@fgiova fgiova commented Sep 2, 2025

  • use biome.js for formatting and linting
  • move to qlty
  • esm/cjs build

Copilot AI review requested due to automatic review settings September 2, 2025 15:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the project's development toolchain by replacing ESLint with Biome.js for formatting and linting, updating to qlty for code quality metrics, and adding ESM/CJS build support.

Key changes:

  • Replace ESLint configuration with Biome.js for improved TypeScript support and formatting
  • Update dependencies to newer versions including Node 20 as minimum version
  • Add dual ESM/CJS build support through package.json exports

Reviewed Changes

Copilot reviewed 19 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Update dependencies, add ESM/CJS exports configuration, switch build tooling
biome.json Add Biome.js configuration file
.eslintrc.js/.eslintignore Remove ESLint configuration files
.nvmrc Update Node version from 18 to 20
.github/workflows/node.js.yml Update CI to use qlty and test Node 24
README.md Update badges to use qlty instead of CodeClimate
src/ files Apply Biome formatting rules and add biome-ignore comments
test/ files Apply Biome formatting, fix imports to use node: prefix, update test syntax

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread test/test/queue-hooks.ts
queueARN,
handler: async (message: Message) => {
return {success: true};
handler: async () => {
Copy link

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handler function parameter message has been removed but the function is supposed to handle Message objects. This creates inconsistency with the expected handler signature and could indicate incomplete refactoring.

Suggested change
handler: async () => {
handler: async (message: Message) => {

Copilot uses AI. Check for mistakes.
Comment thread test/test/index.ts
Comment on lines +56 to 57
// @ts-expect-error
handler,
Copy link

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using @ts-expect-error to suppress TypeScript errors for the handler suggests a type mismatch that should be properly resolved rather than suppressed.

Copilot uses AI. Check for mistakes.
Comment thread test/test/error.ts
Comment on lines +56 to +57
// @ts-expect-error
onHandlerTimeout,
Copy link

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @ts-expect-error directive is being used to suppress type errors for the hook assignment. This indicates a type mismatch that should be resolved properly.

Copilot uses AI. Check for mistakes.
- use biome.js for formatting and linting
- move to qlty
- esm/cjs build
@fgiova fgiova force-pushed the feat/update-dependencies branch from ef2b0d3 to 35a4abc Compare September 2, 2025 15:48
@fgiova fgiova merged commit 0b45987 into main Sep 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants