Skip to content

fix: fix hook types and add attributeNames to consumer options#6

Merged
fgiova merged 1 commit into
mainfrom
fix/fix-hooks
Sep 3, 2025
Merged

fix: fix hook types and add attributeNames to consumer options#6
fgiova merged 1 commit into
mainfrom
fix/fix-hooks

Conversation

@fgiova
Copy link
Copy Markdown
Owner

@fgiova fgiova commented Sep 3, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 3, 2025 14:17
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes hook types to allow more flexible return values and adds the attributeNames option to consumer configuration for SQS message attributes.

  • Updates hook type definitions to support both async and sync returns with optional void/undefined values
  • Adds attributeNames configuration option to specify which SQS message attributes to retrieve
  • Replaces TypeScript @ts-expect-error comments with Biome lint ignore directives in test files

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

File Description
src/index.ts Adds attributeNames option and updates hook types with flexible return values
src/hooks.ts Improves hook execution logic to handle optional return values properly
README.md Documents the new attributeNames configuration option
test/test/*.ts Updates TypeScript ignore comments to use Biome lint directives

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/index.ts Outdated
Comment thread src/hooks.ts
@fgiova fgiova merged commit 2e3d3b6 into main Sep 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants