fix: fix hook types and add attributeNames to consumer options#6
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes hook types to allow more flexible return values and adds the attributeNames option to consumer configuration for SQS message attributes.
- Updates hook type definitions to support both async and sync returns with optional void/undefined values
- Adds
attributeNamesconfiguration option to specify which SQS message attributes to retrieve - Replaces TypeScript
@ts-expect-errorcomments with Biome lint ignore directives in test files
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/index.ts | Adds attributeNames option and updates hook types with flexible return values |
| src/hooks.ts | Improves hook execution logic to handle optional return values properly |
| README.md | Documents the new attributeNames configuration option |
| test/test/*.ts | Updates TypeScript ignore comments to use Biome lint directives |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
be46509 to
50fee57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.