Conversation
Owner
|
Sorry, completely missed this and happened upon it by chance! |
Owner
There was a problem hiding this comment.
Hm, thought it was obvious that it needs to be executable. Well wouldn't hurt to mention this, but I think this should be done above, under Script usage, because that part already assumes that the script is executable.
|
Furthermore, on ubuntu 14.04, launching this script at boot cause the creation of pid files beginning with S20. As an exemple : and after reboot, in /var/run/ : And this cause the restart and stop of the service failing because the script's function is_running() always return false. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a quick note about starting automatically. Thanks for the template!