[WIP] feature proposal: make npzread/write file io variants public#65
Open
Lattay wants to merge 1 commit into
Open
[WIP] feature proposal: make npzread/write file io variants public#65Lattay wants to merge 1 commit into
Lattay wants to merge 1 commit into
Conversation
Lattay
force-pushed
the
doc_npz_fileio
branch
from
e3b9ba4 to
87f1553
Compare
Lattay
changed the title
Lattay
changed the title
Lattay
changed the title
Author
|
Just realized npzread is not as trivial as I thought because of the npz/npy detection. |
Author
What seemed difficult was to not require |
|
Me too. For example, "save"d numpy arrays returned by a REST API may be uuencoded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I found the npzwritearray function useful when combined with something like GZip.open, so I propose to document it to make it public.
The name seems a bit confusing relative to npzwrite, so I also propose to rename it to npzwriteto.
I also did the corresponding change for npzread.
Is this something that would be welcome upstream?