Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates UI behavior around job reruns and tightens handling of SciGateway custom events in the main application component.
Changes:
- Refactors the job rerun handler to
async/awaitand adds a 20s fallback to clear the loading spinner. - Updates SciGateway event handling to compare against
detail.typeusing strict equality instead ofString.match.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/components/jobs/Row.tsx |
Adds a rerun fallback timeout and refactors rerun flow; impacts spinner/snackbar behavior. |
src/App.tsx |
Fixes SciGateway action extraction to use detail.type and compares actions via ===. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pasarus
approved these changes
Mar 17, 2026
Pasarus
requested changes
Mar 17, 2026
Member
Pasarus
left a comment
Pasarus
left a comment
There was a problem hiding this comment.
Copilot just put some egg on my face with this (I think largely this is fine without the changes suggested, but it isn't wrong? so we should probably handle these cases)
Copilot suggestions, let's see how it goes Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #605
Description
Change how scigateway actions are matched, and change handlererun