fix: update iterative strain before convergence check#340
Merged
mortenengen merged 3 commits intodevfrom Mar 26, 2026
Merged
Conversation
…ds if initial strain is present
talledodiego
approved these changes
Mar 26, 2026
Collaborator
talledodiego
left a comment
talledodiego
left a comment
There was a problem hiding this comment.
Perfect! Thanks for having catched this up!
Sorry for having not catched this before hand.
Should we in a next PR make deeper tests on this?
Comment on lines
+1796
to
+1798
| # Calculate the initial response and residuals. Note that the initial | ||
| # residual might be different from the applied loads if any initial | ||
| # strain is present |
Collaborator
There was a problem hiding this comment.
right observation! perfect
Member
Author
Thanks😊 It would be great if we could have a couple of tests that check the actual valeus of the strain plane. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After implementing the result object for calculate strain plane, the order of checking for convergence and updating the iterative strain was changed, resulting in a non-converged strain plane to be returned from the method.