Issue #2349 - Audit-entity generation and automatic auditing (UI Part)#2458
Open
oleh-maikovych wants to merge 47 commits into2.3.0-SNAPSHOTfrom
Open
Issue #2349 - Audit-entity generation and automatic auditing (UI Part)#2458oleh-maikovych wants to merge 47 commits into2.3.0-SNAPSHOTfrom
oleh-maikovych wants to merge 47 commits into2.3.0-SNAPSHOTfrom
Conversation
…can be changed. Introduced abstract entity master with centre.
…PI to add Volatile entity centre.
…s. Enhanced related to compound master classes. Added new standard compound master for auditing.
…d text block for multiline strings in AbstractMasterWithCentre and related places.
…with-embedded-audit-centre
… compound master. Implemented producer, added tokens.
… master can be left. This logic now checks whether entity type is persistent instead of just checking whether it is persisted.
… audit centre, adjusted documenttion.
…on more clear and simple. Also adjusted attributed generation to make it work only when current binding entity changes.
…set element name and import value.
…is needed to initialise audit menu item with entity centre data. This contract will allow to get data from web resource module in pojo-bl or dao module.
… polymorphic centre.
… use it as embedded centre in PersistentEntityInfo compound master.
…lcualte presence of auditing entities
… that it opens compound master if entity is audited and simple master otherwise.
…so that it get triggered only when the master is not a master with embedded view (master with menu)
… Info can execute token to rule openening of simple and compound masters.
…with-embedded-audit-centre
homedirectory
requested changes
Jul 17, 2025
.../src/main/java/ua/com/fielden/platform/entity/AbstractPolymorphicCentreCompoundMenuItem.java
Outdated
Show resolved
Hide resolved
The term "versioning" denotes the act of managing versions of something (e.g., software versioning). In our case, the information is not related to the process of versioning, but to specific pieces of information about an entity, such as its version number, who created/updated it and when. Perhaps, even "version information" is not the best term for this.
homedirectory
approved these changes
Jul 24, 2025
… compound master type is functional.
homedirectory
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be completed by the pull request creator
This section should be completed with reference to section Preparing PR of the Code and PR reviews wiki page.
Create the pull request as a draft by tapping the dropdown arrow on the 'Create pull request' button under the pull request description (below the text box where this description is being edited) and changing the default
Create pull requesttoDraft pull request.Or, if the pull request has already been created, convert it to draft by tapping the "Convert to draft" link beneath the "Reviewers" section.
A self-review of all changes has been completed, and the changes are in sync with the issue requirements.
Changes to the requirements have been reflected in the issue description.
Any "leftovers" such as sysouts, printing of stack traces, and any other "temporary" code, have been removed.
Minor refactorings, such as renamings, extraction of constants, etc., have been addressed.
Developer documentation (e.g., comments, Javadoc), have been provided where required.
All existing and new Java tests pass successfully by running them with Maven.
All existing and new Web tests pass successfully.
Established security practices have been followed, including the existence and attribution of security tokens.
Changes have been inspected for possible NPE situations, and the changes are sufficiently defensive.
Correct transaction demarcation is in place, which is especially important in cases with nested transactional code (e.g., iterative data process), data streams, code shared between interactive actions and calls as part of some other execution workflows, such as background jobs.
The correct base branch has been selected for these changes to be merged into.
The latest changes from the base branch have already been merged into this feature branch (and tested).
Added a change overview to the issue description or as a wiki page, referenced in the issue description.
Some issues might be very descriptive and serve in place of a wiki page.
In such cases consider adding label
Wiki liketo the issue.Changes subject to performance considerations have been evaluated, and tested against production-size data if applicable.
This pull request does not contain significant changes, and at least one appropriate reviewer has been selected.
The
In progresslabel has been removed from the issue.The
Pull requestlabel has been added to the issue.The pull request has been made ready for review by tapping the "Ready for review" button below the list of commits on the pull request page.
To be completed by the pull request reviewer (@homedirectory)
This section should be completed with reference to section Performing PR review of the Code and PR reviews wiki page.
The
In progresslabel has been added to the pull request in GitHub.The correct base branch is specified, and that base branch is up-to-date in the local source.
The issue branch has been checked out locally, and had the base branch merged into it.
All automated tests pass successfully.
Ensure the implementation satisfies the functional requirements.
Ensure that code changes are secure and align with the established coding practices, including code formatting and naming conventions.
Ensure that code changes are documented and covered with automated tests as applicable.
Ensure that code changes are well-suited for informal reasoning.
Ensure that changes are documented for the end-user (a software engineer in the case of TG, or an application user in the case of TG-based applications).
To be completed by the pull request reviewer (@homedirectory) once the changes have been reviewed and accepted
The changes have been merged into the base branch (unless there is a specific request not to do so, e.g., they are to be released to SIT).
The issue branch has been deleted (unless the changes have not been merged - see above, or there is a specific request not to do so).
The
In progresslabel has been removed from the pull request.The
Pull requestlabel has been removed from the issue.