Development - #33
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the repo’s development/CI “golden path” by adding a production-only npm audit gate, updates Prisma to 7.4.0 (plus related lockfile bumps), and adds a new guide for personalizing the starter kit into a concrete product.
Changes:
- Add
audit:prodscript and run it in CI as a runtime dependency vulnerability gate. - Upgrade Prisma (
prisma+@prisma/client) to 7.4.0 and refreshpackage-lock.json. - Add documentation for project personalization and update docs indices to reference it.
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds audit:prod script; bumps Prisma packages to 7.4.0. |
| package-lock.json | Updates lockfile for Prisma bump and other dependency changes; adjusts root engines field. |
| .github/workflows/ci.yml | Runs npm run audit:prod as an explicit CI gate. |
| docs/standards/ci-cd.md | Documents the new runtime dependency audit gate. |
| docs/guide/personalizing-a-project.md | New guide describing how to tailor the kit into a product backend. |
| docs/guide/README.md | Adds the new personalization guide to the guide index. |
| docs/README.md | Adds the new personalization guide to the docs index. |
| README.md | Points template users to the personalization guide and project profile doc. |
| libs/platform/queue/queue.worker.ts | Import formatting cleanup. |
| libs/platform/queue/queue.producer.ts | Import formatting cleanup. |
| libs/platform/config/redis-connection.ts | Removes trailing whitespace/newline. |
| apps/worker/src/jobs/emails.worker.ts | Import formatting cleanup. |
| apps/worker/src/jobs/emails.worker.spec.ts | Fixes indentation/formatting in a test. |
| apps/worker/src/jobs/emails.templates.ts | Removes trailing whitespace/newline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -53,7 +54,7 @@ | |||
| "@opentelemetry/sdk-node": "^0.209.0", | |||
| "@opentelemetry/semantic-conventions": "^1.38.0", | |||
| "@prisma/adapter-pg": "^7.2.0", | |||
There was a problem hiding this comment.
Prisma packages are now out of sync: @prisma/client/prisma were bumped to 7.4.0, but @prisma/adapter-pg is still ^7.2.0 (locks to 7.2.0). Prisma components are expected to stay on the same version to avoid subtle runtime incompatibilities; please bump @prisma/adapter-pg to the matching 7.4.0 (and regenerate the lockfile).
| "@prisma/adapter-pg": "^7.2.0", | |
| "@prisma/adapter-pg": "7.4.0", |
| "@prisma/adapter-pg": "^7.2.0", | ||
| "@prisma/client": "^7.2.0", | ||
| "@prisma/client": "7.4.0", | ||
| "bullmq": "^5.66.4", |
There was a problem hiding this comment.
Upgrading to Prisma 7.4.0 introduces a stricter Node engine requirement (@prisma/client declares ^20.19 || ^22.12 || >=24.0). With engines.node set to 22.x, contributors could use Node 22.0–22.11 which won't satisfy Prisma’s engine range. Consider tightening the repo Node engine to >=22.12 <23 (and keeping CI in sync) to prevent installs/runs on unsupported Node minors.
No description provided.