Support range requests#28
Open
hannahhoward wants to merge 1 commit intomainfrom
Open
Conversation
also removes audio/video exclusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Support range requests in the service worker, allowing audio and video content to be loaded.
Requires an update to the JS Client once filecoin-saturn/js-client#48 merges
Implementation
Range: bytes=0-1000, 1500-2000), and we probably should add a check that excludes these requests. I don't believe the browser tends to use this for audio/video though maybe @gruns knows, but it needs further investigation.Next Steps