Short knob-grid labels for 43 parameter(s) - #1
Open
charlesvestal wants to merge 1 commit into
Open
charlesvestal wants to merge 1 commit into
charlesvestal wants to merge 1 commit into
Conversation
Labels each knob cell with the word that identifies the control rather than a squeezed abbreviation of its full name. Additive only -- the released host (v0.12.1) ignores the field, and its page planner was verified to produce identical pages before and after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
short_nameto this module's parameters, so the Schwung knob grid canlabel each cell with the word that identifies it rather than a squeezed
abbreviation of the full name.
Part of a fleet-wide pass over every catalogued module. Each name was chosen
by hand against the page it appears on: where a page is already called
"Filter Envelope", its cells say ATTACK and DECAY rather than F.ATK and FENVDEC.
What changes
Nothing else is touched: no version bump, no behaviour change, no new params.
fizzik — rendered
Left is what the grid draws today, right is with this change — 8 of 9 changed pages.
Before / after
rnd_patchrnd_excrnd_resonrnd_allftypeexc_mixexc_resovel_levela_modela_structThe page matters where a name repeats: the same role under two sections
gets the same short name, and the section it sits under is what tells
them apart.
The full name is not lost
A short name is what the cell says at rest. The moment a knob is
touched, the header shows that parameter's full name and its value —
so nothing becomes unidentifiable, it just stops being shouted at you
eight times on one page.
rnd_patchon Main: the cell reads PATCH at rest, and the header reads RND PATCH under the finger.Safe to merge now
short_nameis a new field — it lands in the next Schwung release. On thecurrently released host (v0.12.1) it is simply ignored.
This was checked rather than assumed: for every file here, the v0.12.1
page planner was run against the module contract before and after the change
and asserted to produce byte-identical pages — same page count, same cells,
same order. Merging today changes nothing; the labels appear when users update.
If a label is wrong
These are suggestions from someone reading the grid, not from the person who
wrote the synth. Change any of them in this branch, or close it — no hard
feelings either way. Layout problems are a separate matter and will come as
their own issues.