Bump mypy from 2.1.0 to 2.3.0 - #49
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe mypy version is updated from 2.1.0 to 2.3.0 in the development dependency file and the pre-commit configuration. ChangesDevelopment dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@requirements-dev.txt`:
- Line 6: Update the mypy revision in the pre-commit configuration to match the
requirements-dev.txt pin at version 2.3.0, ensuring both development dependency
management and pre-commit checks use the same version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0a444f43-fbee-452f-b753-c9da8ff5f5a4
📒 Files selected for processing (1)
requirements-dev.txt
178fd87 to
5555461
Compare
Bumps [mypy](https://github.com/python/mypy) from 2.1.0 to 2.3.0. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v2.1.0...v2.3.0) --- updated-dependencies: - dependency-name: mypy dependency-version: 2.3.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
5555461 to
f62279b
Compare
Dependabot bumps requirements-dev.txt but not the matching hook rev, so pre-commit type-checks with a different mypy than CI. Here that was two minors apart (v2.1.0 local vs 2.3.0 in CI), enough for the two to disagree on what type-checks. Pins the hook to v2.3.0 to match mypy==2.3.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
## The problem Dependabot bumps `requirements-dev.txt` but has never touched `.pre-commit-config.yaml`. The two drift, and pre-commit ends up linting and type-checking with different versions than CI. This is not hypothetical — it is what blocked **#53** and **#49** since July. CodeRabbit flagged both, correctly, and they sat there. The drift predates them too: `main` had `ruff==0.15.20` pinned against hook `rev: v0.15.17`. | | `requirements-dev.txt` | hook rev (before) | |---|---|---| | ruff | 0.16.1 | v0.15.17 | | mypy | 2.3.0 | v2.1.0 | Two minors apart for mypy is enough for the two to disagree on what type-checks — you pass locally and fail in CI, or the reverse. ## The fix Adds the `pre-commit` ecosystem so Dependabot maintains the hook revs alongside the pip pins: ```yaml - package-ecosystem: pre-commit directory: "/" schedule: interval: weekly ``` `pre-commit` is a [supported ecosystem](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference); `directory: "/"` points at the repo-root `.pre-commit-config.yaml`. YAML validated, all four ecosystems parse: `pip, docker, github-actions, pre-commit`. This stops the drift recurring. #53 and #49 have had their revs synced by hand in their own branches. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Bumps mypy from 2.1.0 to 2.3.0.
Changelog
Sourced from mypy's changelog.
... (truncated)
Commits
8aabf84Drop +dev from version4d8ad2aUpdate changelog for 2.3 release (#21728)2c21546[mypyc] Update documentation of race conditions under free threading (#21726)a9f62a3[mypyc] Make attribute access memory safe on free-threaded builds (#21705)0faa413UsePYODIDEenvironment variable for Emscripten cross-compilation detection...3d75cdb[mypyc] Borrow final attributes more aggressively (#21702)24c237d[mypyc] Improve documentation of Final (#21713)b5be217[mypyc] Update free threading Python compatibility docs (#21711)cbcb51aNarrow for frozendict membership check (#21709)af2bc0fSync typeshed (#21707)