Bump ruff from 0.15.20 to 0.16.1 - #53
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRuff is updated to version 0.16.1 in the development requirements and pre-commit configuration. ChangesRuff tooling update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@requirements-dev.txt`:
- Line 5: Update the Ruff version pin in the pre-commit configuration to v0.16.0
so the astral-sh/ruff-pre-commit hook matches the ruff==0.16.0 dependency in
requirements-dev.txt.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e7e0ac6e-25fd-4e70-81a7-37869dfada7d
📒 Files selected for processing (1)
requirements-dev.txt
| pytest-cov==7.1.0 | ||
| responses==0.26.1 | ||
| ruff==0.15.20 | ||
| ruff==0.16.0 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
set -e
printf '\n== requirements-dev.txt ==\n'
cat -n requirements-dev.txt
printf '\n== .pre-commit-config.yaml ==\n'
cat -n .pre-commit-config.yaml
printf '\n== CI/workflow Ruff references ==\n'
rg -n "ruff|pre-commit|requirements-dev" .github . -g '!**/.git/**'Repository: finallyjay/packagist-tracker
Length of output: 2146
🏁 Script executed:
set -e
git ls-files 'requirements-dev.txt' '.pre-commit-config.yaml' '.github/**' | sed -n '1,200p'Repository: finallyjay/packagist-tracker
Length of output: 373
🏁 Script executed:
set -e
printf 'root:%s\n' "$PWD"
ls -1Repository: finallyjay/packagist-tracker
Length of output: 371
Align the Ruff pre-commit hook with requirements-dev.txt. .pre-commit-config.yaml still pins astral-sh/ruff-pre-commit to v0.15.17 while requirements-dev.txt uses ruff==0.16.0, so local hooks and CI run different Ruff versions. Bump the hook to v0.16.0.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@requirements-dev.txt` at line 5, Update the Ruff version pin in the
pre-commit configuration to v0.16.0 so the astral-sh/ruff-pre-commit hook
matches the ruff==0.16.0 dependency in requirements-dev.txt.
6f1f84a to
c31c597
Compare
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.15.20 to 0.16.1. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.15.20...0.16.1) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.16.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
c31c597 to
45f270c
Compare
Dependabot bumps requirements-dev.txt but not the matching hook rev, so the two drift and pre-commit lints with a different ruff than CI. Pins the hook to v0.16.1 to match ruff==0.16.1. Note the drift predates this PR: main had ruff==0.15.20 against rev v0.15.17. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
# Conflicts: # requirements-dev.txt
Requested change has been made. The ruff pre-commit hook rev was synced to v0.16.1 to match ruff==0.16.1, and main's mypy==2.3.0 / rev v2.3.0 was merged in. All four values now agree; all 7 checks pass, including CodeRabbit's own. Dismissing as stale — the review predates the fix by 8 days.
## The problem Dependabot bumps `requirements-dev.txt` but has never touched `.pre-commit-config.yaml`. The two drift, and pre-commit ends up linting and type-checking with different versions than CI. This is not hypothetical — it is what blocked **#53** and **#49** since July. CodeRabbit flagged both, correctly, and they sat there. The drift predates them too: `main` had `ruff==0.15.20` pinned against hook `rev: v0.15.17`. | | `requirements-dev.txt` | hook rev (before) | |---|---|---| | ruff | 0.16.1 | v0.15.17 | | mypy | 2.3.0 | v2.1.0 | Two minors apart for mypy is enough for the two to disagree on what type-checks — you pass locally and fail in CI, or the reverse. ## The fix Adds the `pre-commit` ecosystem so Dependabot maintains the hook revs alongside the pip pins: ```yaml - package-ecosystem: pre-commit directory: "/" schedule: interval: weekly ``` `pre-commit` is a [supported ecosystem](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference); `directory: "/"` points at the repo-root `.pre-commit-config.yaml`. YAML validated, all four ecosystems parse: `pip, docker, github-actions, pre-commit`. This stops the drift recurring. #53 and #49 have had their revs synced by hand in their own branches. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Bumps ruff from 0.15.20 to 0.16.1.
Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
80790b3Bump 0.16.1 (#27330)63830f3[ty] Borrow from constraint set storage less often (#27328)f40dca9[ty] Preserve forwarded expanded-variadic diagnostic sources (#27266)0d80497Lint TOML files in the LSP (#26862)d91586bUpdate prek dependencies (#27293)7da4b8b[ty] Respect bounds and constraints in generic materializations (#27228)b20daf7[ty] refactor: add helper function to send partial results (#27249)4d4c8fa[ty] Emit diagnostic when specializing a non-generic class (#26883)7c3e2db[ty] Fix enum class container assignability (#27318)d5ef97f[flake8-return] Fix false positive when variable is read infinallyclaus...