Skip to content

feat: 베타 도메인 CORS 허용 및 yml 설정 분리#503

Merged
Yoosejeong merged 3 commits into
developfrom
feat/#502
Jun 28, 2026
Merged

feat: 베타 도메인 CORS 허용 및 yml 설정 분리#503
Yoosejeong merged 3 commits into
developfrom
feat/#502

Conversation

@Yoosejeong

@Yoosejeong Yoosejeong commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

🧩 관련 이슈

🛠️ 작업 내용

  • CORS 허용 Origin 목록을 SecurityConfig 하드코딩 방식에서 yml 설정 기반으로 분리했습니다.
  • CorsProperties를 추가하여 cors.allowed-origin-patterns 설정값을 바인딩하도록 구성했습니다.
  • 베타 프론트 도메인을 CORS 허용 Origin에 포함할 수 있도록 설정 관리 구조를 개선했습니다.

📢 참고 및 특이사항

✅ 체크리스트

  • Merge 대상 브랜치가 develop 인지 확인
  • PR 제목 형식 준수 (예: feat: 로그인 기능 구현)
  • 관련 이슈 연결 (close #이슈번호)
  • 불필요한 코드/주석 제거
  • 기능 정상 작동 확인

@Yoosejeong Yoosejeong self-assigned this Jun 28, 2026
@Yoosejeong Yoosejeong added the ✨ feature 새로운 기능 추가 label Jun 28, 2026
@Yoosejeong Yoosejeong linked an issue Jun 28, 2026 that may be closed by this pull request
6 tasks
@Yoosejeong Yoosejeong added the D-0 12시간 이내에 처리가 필요합니다. label Jun 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request externalizes the CORS allowed origin patterns by introducing a new 'CorsProperties' configuration class and injecting it into 'SecurityConfig'. The review feedback suggests improving 'CorsProperties' by replacing '@configuration' with '@component' and utilizing constructor binding to ensure immutability and null safety.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/com/fmi/config/CorsProperties.java
@Yoosejeong Yoosejeong merged commit 2ff3ff9 into develop Jun 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D-0 12시간 이내에 처리가 필요합니다. ✨ feature 새로운 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] 베타 도메인 CORS 허용 및 yml 설정 분리

1 participant