Skip to content

feat: 콘텐츠 영역 최소 너비 적용#85

Merged
wlrnjs merged 2 commits into
developfrom
feat/root-app
Jun 20, 2026
Merged

feat: 콘텐츠 영역 최소 너비 적용#85
wlrnjs merged 2 commits into
developfrom
feat/root-app

Conversation

@wlrnjs

@wlrnjs wlrnjs commented Jun 19, 2026

Copy link
Copy Markdown
Member

Pull Request

관련 이슈

  • close #이슈번호

작업 내용

  • 화면에서 UI 요소가 시안보다 크게 표시되면서, 작은 화면에서 레이아웃이 깨지는 문제가 있었습니다.
  • 사이드바를 제외한 오른쪽 콘텐츠 영역에 min-w-[1520px]을 추가했습니다.
  • 화면 너비가 부족한 경우 X축 스크롤이 발생하도록 하여 UI 깨짐을 최소화했습니다.

참고 사항

  • 이번 작업은 전체 반응형 구조를 수정하기보다, 모니터링 화면의 최소 너비를 보장하는 방식으로 대응했습니다.
  • 추후 사용 범위가 확대될 경우 반응형 기준 재검토가 필요합니다.

체크리스트

  • 기능이 정상 동작하는지 확인
  • 불필요한 코드/주석 제거

@wlrnjs wlrnjs requested a review from junye0l June 19, 2026 17:11
@wlrnjs wlrnjs self-assigned this Jun 19, 2026
@wlrnjs wlrnjs added D-0 12시간 이내에 처리가 필요합니다. feature 새로운 기능 추가, 요구사항 반영 labels Jun 19, 2026
@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
finditem-monitoring Ready Ready Preview, Comment Jun 20, 2026 1:23pm
finditem-monitoring-server Ready Ready Preview, Comment Jun 20, 2026 1:23pm

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

모니터링 화면의 UI 요소가 작은 화면에서 의도치 않게 깨지는 문제를 해결하기 위해 콘텐츠 영역의 최소 너비를 고정하고 스크롤 기능을 추가했습니다. 또한, 레이아웃 변경에 따른 로딩 스피너와 사이드바의 스타일을 보완하여 안정적인 사용자 경험을 제공하도록 개선했습니다.

Highlights

  • 콘텐츠 영역 최소 너비 설정: 레이아웃 깨짐 방지를 위해 콘텐츠 영역에 min-w-[1520px]을 적용하고 X축 스크롤을 활성화했습니다.
  • 레이아웃 안정성 보완: 콘텐츠 영역 변경에 맞춰 로딩 스피너의 위치를 absolute로 조정하고, 사이드바에 z-index를 추가하여 시각적 일관성을 확보했습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


좁은 화면에 레이아웃 무너질 때, 고정된 너비로 중심을 잡네. 스크롤은 생겨나고 평온이 오니, 이제는 안심하고 모니터링하리.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces layout adjustments to the main application container, sidebar, and authentication route loading state. Specifically, it wraps the routes in a container with a minimum width of 1520px and adds relative positioning. The reviewer noted that applying this minimum width globally causes layout issues, such as unnecessary horizontal scrollbars on the login page, 404 page, and during loading states. They recommended applying the minimum width constraint individually to the specific monitoring pages that actually require it.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread apps/monitor-web/src/App.tsx
@wlrnjs wlrnjs merged commit 5b7ff7c into develop Jun 20, 2026
4 checks passed
@wlrnjs wlrnjs deleted the feat/root-app branch June 20, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D-0 12시간 이내에 처리가 필요합니다. feature 새로운 기능 추가, 요구사항 반영

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants