Skip to content

design: 404 페이지 퍼블리싱 수정#91

Merged
wlrnjs merged 1 commit into
developfrom
design/not-found
Jun 25, 2026
Merged

design: 404 페이지 퍼블리싱 수정#91
wlrnjs merged 1 commit into
developfrom
design/not-found

Conversation

@wlrnjs

@wlrnjs wlrnjs commented Jun 25, 2026

Copy link
Copy Markdown
Member

Pull Request

관련 이슈

  • close #이슈번호

작업 내용

  • 변경된 404 페이지에 맞게 퍼블리싱을 수정했습니다.
screencapture-localhost-3000-asdo-2026-06-25-23_26_07

참고 사항

  • 별도 기능 추가는 없습니다.

체크리스트

  • 기능이 정상 동작하는지 확인
  • 불필요한 코드/주석 제거

@wlrnjs wlrnjs requested a review from junye0l June 25, 2026 14:26
@wlrnjs wlrnjs self-assigned this Jun 25, 2026
@wlrnjs wlrnjs added D-3 3일 이내에 처리가 필요합니다. design CSS, 레이아웃, 반응형, 퍼블리싱 관련 수정 labels Jun 25, 2026
@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
finditem-monitoring Ready Ready Preview, Comment Jun 25, 2026 2:26pm
finditem-monitoring-server Ready Ready Preview, Comment Jun 25, 2026 2:26pm

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

본 PR은 404 페이지의 디자인 가이드라인에 맞춰 퍼블리싱을 최적화하는 작업을 포함합니다. 컴포넌트 간의 간격 조정 및 사용자 경험을 고려한 텍스트 변경을 통해 페이지의 일관성을 개선했습니다.

Highlights

  • UI/UX 업데이트: 404 페이지의 디자인 변경 사항을 반영하여 레이아웃 간격과 문구를 수정했습니다.
  • 문구 변경: 오류 메시지를 '요청하신 페이지를 찾을 수 없습니다.'로 변경하고, 버튼 텍스트를 '메인 페이지로 이동'으로 업데이트했습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


길을 잃은 사용자, 404의 낯선 화면, 메인으로 돌아가는 길, 새로운 문구로 안내하네.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the NotFound page component by adjusting layout spacing, updating the error message to be more generic, and changing the navigation button text to '메인 페이지로 이동'. The review feedback recommends replacing the button and its onClick handler with a Link component to improve web accessibility and support native browser navigation features.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread apps/monitor-web/src/pages/NotFound/NotFound.tsx

@junye0l junye0l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

길을 잃은 사용자, 404의 낯선 화면, 메인으로 돌아가는 길, 새로운 문구로 안내하네.

수고하셨습니다!

@wlrnjs wlrnjs merged commit 04d8e88 into develop Jun 25, 2026
5 checks passed
@wlrnjs wlrnjs deleted the design/not-found branch June 25, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D-3 3일 이내에 처리가 필요합니다. design CSS, 레이아웃, 반응형, 퍼블리싱 관련 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants