Skip to content

refactor : dashboard 일부 수정 및 공통 기능 추가#93

Merged
junye0l merged 4 commits into
developfrom
refactor/dashboard
Jun 28, 2026
Merged

refactor : dashboard 일부 수정 및 공통 기능 추가#93
junye0l merged 4 commits into
developfrom
refactor/dashboard

Conversation

@junye0l

@junye0l junye0l commented Jun 26, 2026

Copy link
Copy Markdown
Member

Pull Request

관련 이슈

  • close #이슈번호

작업 내용

  • App.tsx

    • 라우트 변경 시 메인 스크롤 영역을 초기화할 수 있도록 mainRef 추가

    • ScrollToTop 컴포넌트를 메인 스크롤 컨테이너 내부에 배치

  • ScrollToTop.tsx

    • 라우트 변경 시 지정한 스크롤 컨테이너를 최상단으로 이동시키는 컴포넌트 추가

    • useLocationpathname 변경을 기준으로 스크롤 위치 초기화 처리

    • window가 아닌 targetRef로 전달된 실제 스크롤 컨테이너를 제어하도록 구현

  • DashboardApiList.tsx

    • 전체 API 목록 행 클릭 시 해당 API 상세 페이지로 이동하도록 라우팅 처리 추가

    • useNavigate를 사용해 /api/:apiId 경로로 이동

    • 클릭 가능한 행임을 인지할 수 있도록 hover 스타일과 cursor 스타일 추가

  • DashboardResponseStatusChart.tsx

    • 응답 상태 도넛 차트 영역의 포인터 이벤트 비활성화

    • 차트 섹터 클릭/포커스 등 불필요한 인터랙션 방지

참고 사항

  • 브라우저는 기본적으로 새 페이지로 이동할 때 문서를 다시 로드하면서 스크롤 위치를 최상단으로 초기화하지만, React Router 기반 SPA에서는 실제 문서 이동 없이 라우트에 해당하는 컴포넌트만 교체되기 때문에 기존 스크롤 위치가 유지될 수 있습니다.

  • 프로젝트 기본 구조가 window가 아닌 main 요소가 스크롤 컨테이너이므로, 라우트 변경 시 해당 요소의 스크롤 위치를 직접 최상단으로 초기화했습니다.

체크리스트

  • 기능이 정상 동작하는지 확인
  • 불필요한 코드/주석 제거

@junye0l junye0l added D-1 24시간 이내에 처리가 필요합니다. feature 새로운 기능 추가, 요구사항 반영 refactor 코드 리팩터링, 구조 개선, 클린 코드 작업 labels Jun 26, 2026
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
finditem-monitoring Ready Ready Preview, Comment Jun 26, 2026 6:58pm
finditem-monitoring-server Ready Ready Preview, Comment Jun 26, 2026 6:58pm

@finditem-bot finditem-bot Bot requested a review from wlrnjs June 26, 2026 18:57
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces improvements to the dashboard's navigation and user experience. It addresses scroll position persistence issues common in SPA architectures by ensuring the main content area resets upon navigation. Additionally, it enhances interactivity by enabling row-based navigation in the API list and refining chart interactions.

Highlights

  • Scroll Management: Implemented a ScrollToTop component that resets the scroll position of the main container to the top whenever the route changes.
  • Dashboard Navigation: Added click navigation to the API list rows, allowing users to navigate directly to specific API detail pages.
  • UI/UX Improvements: Disabled pointer events on the response status donut chart to prevent unnecessary interactions and added hover styles to the API list table rows.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


The routes shift fast in React's flow, / But scroll positions stayed below. / A ref was set, the top was found, / Now navigation feels quite sound.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a ScrollToTop component to reset the scroll position of the main container upon route changes, adds row-click navigation to the API list in the Dashboard, and disables pointer events on the response status chart. Regarding the feedback, it is recommended to replace the onClick navigation on the table row (tr) with a standard Link component for the API name column to improve accessibility and support native browser navigation features like opening in a new tab.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@wlrnjs wlrnjs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 수고하셨습니다!

@junye0l junye0l merged commit 3201065 into develop Jun 28, 2026
4 checks passed
@junye0l junye0l deleted the refactor/dashboard branch June 28, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D-1 24시간 이내에 처리가 필요합니다. feature 새로운 기능 추가, 요구사항 반영 refactor 코드 리팩터링, 구조 개선, 클린 코드 작업

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants