Skip to content

Conversation

@michaelgatuma
Copy link
Contributor

No description provided.

@michaelgatuma michaelgatuma added the documentation Improvements or additions to documentation label Oct 2, 2023
@vercel
Copy link

vercel bot commented Oct 2, 2023

@michaelgatuma is attempting to deploy a commit to the Finsweet Team on Vercel.

To accomplish this, @michaelgatuma needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@michaelgatuma michaelgatuma self-assigned this Oct 2, 2023
@michaelgatuma
Copy link
Contributor Author

michaelgatuma commented Oct 24, 2023

Closes #468

@robertkibet
Copy link
Contributor

robertkibet commented Oct 24, 2023

@michaelgatuma we can also clean up other readme files that have an outdated finsweet core script approach

for example: https://github.com/finsweet/attributes/blob/v2-utils-documentation/packages/attributes/README.md
has examples using:

<!-- outdated -->
<finsweet-attributes fs-SOLUTION ></finsweet-attributes>

plus any other place that still has this referece of <finsweet-attributes/> tag usage:

Have a look at this slack comment by @alexiglesias93 to understand more how to update these references https://finsweet.slack.com/archives/C024EDXEC7P/p1693151968124669

@alexiglesias93 alexiglesias93 added this to the 2024 Q1 milestone Jan 16, 2024
Base automatically changed from v2 to master March 21, 2024 18:41
Copy link
Contributor

@robertkibet robertkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelgatuma please chekout latest udpate, v2 has been merged into master, you can update this PR to latest when you find the time 👍

@michaelgatuma
Copy link
Contributor Author

Thank you @robertkibet for the heads up 👍 . I will check it out and update what needs updating

@michaelgatuma michaelgatuma linked an issue Mar 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document all internal utils

3 participants