Skip to content

Conversation

@therobrob
Copy link
Member

@therobrob therobrob commented Dec 26, 2025

  • refactored expander-code
  • split up faq markdown
  • added faq in structured data
  • introduced weight-property to faq-markdown-files

@github-actions
Copy link

github-actions bot commented Dec 26, 2025

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@therobrob therobrob linked an issue Dec 26, 2025 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Dec 26, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 3a424b0
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/695922c435b38b0008048b9e
😎 Deploy Preview https://deploy-preview-545--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@therobrob therobrob added content Improvements or additions to the content (countries, news, operators, general content) technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. labels Dec 26, 2025
@therobrob therobrob marked this pull request as ready for review December 28, 2025 20:10
@therobrob therobrob requested a review from lenderom December 28, 2025 20:10
Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good idea for structuring the FAQ content, I like it 👍

@therobrob therobrob requested a review from MoritzWeber0 January 3, 2026 11:45
@therobrob
Copy link
Member Author

therobrob commented Jan 3, 2026

now there’s an separate faq-page.. 🙄
i had to add the index-files because the faq articles weren’t rendered before..

@MoritzWeber0
Copy link
Member

now there’s an separate faq-page.. 🙄 i had to add the index-files because the faq articles weren’t rendered before..

I had a similar issue in another PR and found a solution for it. I'll try it out and push it if it works.

@MoritzWeber0
Copy link
Member

MoritzWeber0 commented Jan 3, 2026

I pushed to changes, let's see if it works in the preview:

  • Updated where $gi.Pages ".File.Dir" "==" "generalinformation/faq/" to $faq.Pages (it didn't work anymore with directories)
  • Added Hugo build options, so that FAQ pages can be listed in a local context, but are not rendered to separate pages. The options are only applied during build and not for hugo server, so don't wonder the page is still rendered locally.

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

https://search.google.com/test/rich-results/result/r%2Ffaq?id=31sLBDOc8Ajg502ff9_z7A&hl=de

Seems to work, thank you @therobrob ❤️
You can review my latest changes and if they are fine for you, feel free to merge.

@therobrob therobrob merged commit 1501ee4 into main Jan 3, 2026
7 checks passed
@therobrob therobrob deleted the feat/structured-faq branch January 3, 2026 14:17
@therobrob
Copy link
Member Author

Image https://search.google.com/test/rich-results/result/r%2Ffaq?id=31sLBDOc8Ajg502ff9_z7A&hl=de

Seems to work, thank you @therobrob ❤️ You can review my latest changes and if they are fine for you, feel free to merge.

Really cool, thank you too! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Improvements or additions to the content (countries, news, operators, general content) technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Structured data for "General Information" / FAQ

3 participants