feat: support for readers that remove disturbing elements #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
therobrob
added
the
technical
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
It seems to be working in safari :)
|
MoritzWeber0
approved these changes
Jan 2, 2026
Member
MoritzWeber0
left a comment
MoritzWeber0
left a comment
There was a problem hiding this comment.
Cool, thanks for the simple solution!
The only remaining thing I noticed are duplicated <hr> elements in those readers, but we can look at it at another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i’ve tried option 2, mentioned in #419, to solve the problem. So i’ve moved the icon-naming to an before-element.
We have to check, if it solves the problem.
@MoritzWeber0, have you thought of any further adjustments?