Skip to content

add Next snippets - #421

Open
morganchen12 wants to merge 9 commits into
masterfrom
mc/next
Open

morganchen12 wants to merge 9 commits into
masterfrom
mc/next

Conversation

@morganchen12

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new Swift code snippets to PipelineSnippets.swift demonstrating Firestore pipeline stages for sub-pipeline joins, including define, toArrayExpression, and toScalarExpression. The review feedback identifies several instances where newly defined variables are unused, which would trigger compiler warnings, and suggests printing these variables to maintain consistency with other snippets in the file.

Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
@morganchen12 morganchen12 changed the title add subquery snippets add Next snippets Apr 10, 2026
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift Outdated
* add explain and join snippets

* add prints to silence warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants