add explain and join snippets - #424
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Xcode project to use remote package references for the Firebase iOS SDK instead of local ones, and adds numerous pipeline snippets to PipelineSnippets.swift demonstrating advanced Firestore features like joins, search, and aggregations. The review feedback highlights duplicate and dangling package references in the project file that should be cleaned up, and points out that several newly added snippet methods assign the query execution results to an unused results variable, which will trigger Swift compiler warnings. It is recommended to print these results to resolve the warnings and maintain consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.