Skip to content

add explain and join snippets - #424

Merged
morganchen12 merged 2 commits into
mc/nextfrom
antigravity-pipeline-snippets
Jul 31, 2026
Merged

morganchen12 merged 2 commits into
mc/nextfrom
antigravity-pipeline-snippets

Conversation

@morganchen12

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Xcode project to use remote package references for the Firebase iOS SDK instead of local ones, and adds numerous pipeline snippets to PipelineSnippets.swift demonstrating advanced Firestore features like joins, search, and aggregations. The review feedback highlights duplicate and dangling package references in the project file that should be cleaned up, and points out that several newly added snippet methods assign the query execution results to an unused results variable, which will trigger Swift compiler warnings. It is recommended to print these results to resolve the warnings and maintain consistency.

Comment thread firestore/swift/firestore-smoketest.xcodeproj/project.pbxproj
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
Comment thread firestore/swift/firestore-smoketest/PipelineSnippets.swift
@morganchen12
morganchen12 changed the base branch from master to mc/next July 31, 2026 23:07
@morganchen12
morganchen12 merged commit db5996f into mc/next Jul 31, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant