Conversation
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary Word documents retain text deleted with Track Changes enabled. The DOC parser currently emits that text alongside its replacement, so a replacement such as
old->newbecomesoldnewin Markdown. This change omits deleted revision text while retaining insertions and ordinary strikethrough.Resolve
sprmCFRMarkDelin CHPX and piece modifiers, including the Prm0 mapping and the0x80/0x81toggle operands. Revision state stays internal to the DOC parser; public models, bindings, dependencies, and lockfiles are unchanged. Deleted ordinary paragraph marks join adjacent text, field delimiters stay balanced, and table cell/row boundaries remain in place. Deleted note references also suppress their note bodies so the renderer cannot emit them as unreferenced notes.This is deletion-aware text extraction, with table boundaries preserved as documented in the README. It does not accept structural table revisions or edit the source document.
The implementation follows MS-DOC character properties, ToggleOperand, Prm0, and UpxChpx. Revision properties are forbidden in style definitions, so the deletion toggle's style base is the default false.
Validation:
cargo test --locked: 307 passed, one existing private-corpus test ignored. Existing fixture snapshots are unchanged.cargo fmt --all --checkand workspace Clippy with all targets/features and-D warnings: passed.npm test: 19 passed; generated bindings unchanged.-D warnings, release build with wasm-pack 0.15.0, andnode --test wasm/test.mjs: 8 passed.Local validation used Windows x86_64, Rust 1.96.0, Node 25.4.0, and Python 3.13.0. The repository's Linux CI has not been run for this branch yet.
This change was developed and reviewed with AI assistance. Validation commands above were executed locally by the coding agent.
Summary by cubic
Fixes DOC parsing so text deleted with Track Changes is omitted from Markdown output instead of being concatenated with its replacement (
old->newnow yieldsnewrather thanoldnew). Insertions and ordinary strikethrough are still kept, and table cell/row boundaries remain intact.sprmCFRMarkDeltoggle in character runs and piece modifiers, including Prm0 mapping and0x80/0x81operands.Written for commit 96d5998. Summary will update on new commits.