Draft
Conversation
…ts of different sizes
…ion to handle nested tensor-product cells + added tests
…ation works properly for symbolic points
…ds to work on different array shapes
…xpressions representing point sets
…rately with singleton contractions
…ons work on GEM tensor expressions
…_barycentric_coordinates in tp cells
…plicies and tensor product cells
… sub-entities of simplicies + added notes + modified test checking facet ordering of bary coords on tp cells
|
This appears to include a bunch of work from #246. I'm not sure what to review and what to ignore. |
Author
Basically all the GEM stuff. I think the reason why it's showing the FIAT here is because I branched it off #246 which hasn't been merged yet. Ultimately, we would want this PR to get merged after #246 since it would allow everything there to work on GEM nodes. |
Author
|
Some remaining things to work on here include:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second part of PR #245 and concerns changes to GEM only. In summary, this adds new ways in which
gemNodes can be indexed, mimickingnumpy's fancy indexing:tensor_1d[1,2,3] using a new GEM index type calledListIndex` that wraps the index array and a free index that ranges over the elements of that array.tensor_2d[1::3, [2, 3, 4]].