fix(filler): replace timestamp filename with uuid4 to prevent race condition#202
Open
Pbhacks wants to merge 1 commit intofireform-core:mainfrom
Open
fix(filler): replace timestamp filename with uuid4 to prevent race condition#202Pbhacks wants to merge 1 commit intofireform-core:mainfrom
Pbhacks wants to merge 1 commit intofireform-core:mainfrom
Conversation
…ndition Resolves fireform-core#198 The output PDF filename was generated using datetime.now().strftime('%Y%m%d_%H%M%S') which has only 1-second resolution. Two concurrent requests in the same second produced identical output paths, causing one to silently overwrite the other. Replaced with uuid4() to guarantee globally unique filenames regardless of timing.
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition in the PDF filler by changing how filled PDF output filenames are generated, ensuring concurrent requests cannot collide on the same output path.
Changes:
- Replace timestamp-based output filename suffix (1-second resolution) with a
uuid4()-based suffix for global uniqueness.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #198
The output PDF filename was generated using
datetime.now().strftime('%Y%m%d_%H%M%S')which has only 1-second resolution. Two concurrent requests in the same second produced identical output paths, causing one to silently overwrite the other.Replaced with
uuid4()to guarantee globally unique filenames regardless of timing