Fix runtime errors in main.py (Union import, Fill reference, target_f…#219
Open
lil-aditya wants to merge 1 commit intofireform-core:mainfrom
Open
Fix runtime errors in main.py (Union import, Fill reference, target_f…#219lil-aditya wants to merge 1 commit intofireform-core:mainfrom
lil-aditya wants to merge 1 commit intofireform-core:mainfrom
Conversation
…ields type mismatch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several runtime errors in
src/main.pythat prevent the application from running correctly.Issues Fixed
1. Missing
UnionImportUnion[str, os.PathLike]was used in a type hint butUnionwas not imported fromtyping, causing aNameErrorduring module import.2. Invalid
FillReferenceThe function
run_pdf_fill_processcalledFill.fill_form(...)while theFillimport was commented out.This resulted in a runtime
NameError.The implementation was updated to use the existing
Controllerclass:Fixes #218