fix: Add missing libgl dependency resolving cv2 crash and expose API port (Fixes #223)#225
Open
RITVIKKAMASETTY wants to merge 1 commit intofireform-core:mainfrom
Open
Conversation
RITVIKKAMASETTY
force-pushed
the
fix/docker-env-setup
branch
from
55a67cc to
28e330d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the out-of-the-box local development experience. The
python:3.11-slimbase image strips out several C libraries, leading to an immediateImportError: libGL.so.1crash when starting the FastAPI server becausecommonformsrelies on OpenCV.Additionally, port 8000 was not exposed in the docker compose file, preventing the host machine from hitting the API.
Changes Made
Dockerfile: Addedlibgl1andlibglib2.0-0to theapt-getsystem dependencies.docker-compose.yml: Addedports: - "8000:8000"to theappservice so developers can interact with the API endpoints locally.Testing Performed
make buildsuccessfully.make up, successfully launcheduvicorninside the container without the OpenCV crash, and successfully routed aPOSTrequest from the host machine tohttp://localhost:8000/templates/create.Fixes [BUG]: Docker Environment Fails to Start API (Missing libGL and Port mapping) #224