test(security): OWASP Top 10 security audit + path traversal fix#4
Open
gracefullight wants to merge 1 commit intomainfrom
Open
test(security): OWASP Top 10 security audit + path traversal fix#4gracefullight wants to merge 1 commit intomainfrom
gracefullight wants to merge 1 commit intomainfrom
Conversation
…ersal fix - Add comprehensive security test suite covering OWASP Top 10 categories: A01 (Broken Access Control), A02 (Cryptographic Failures), A03 (Injection), A04 (Insecure Design), A05 (Security Misconfiguration), A07 (Rate Limiting), A08 (Data Integrity), A09 (Logging) - Test cross-user access scoping and workspace isolation - Test agent environment isolation (secret leakage prevention) - Test template/prompt/command injection sanitization - Fix path traversal vulnerability in WorkspaceManager.deriveKey(): collapse consecutive dots to prevent "../" bypass after char substitution Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkspaceManager.deriveKey()— consecutive dots (..) after character substitution could bypass workspace isolationSecurity Findings
CRITICAL
deriveKey("../../etc/passwd")produced".._.._.._etc_passwd"which still contained..(FIXED)HIGH
/statusendpoint — exposes active workspace info to unauthenticated callersMEDIUM
LOW
X-Content-Type-Optionssecurity header on responsesTest plan
validate.sharchitecture check passes..sequences collapsed to single.🤖 Generated with Claude Code