Skip to content

fix: resolve SonarCloud Quality Gate failures and improve marketplace readiness - #10

Merged
ClaudiaFang merged 7 commits into
masterfrom
fix/sonarcloud-failure
Apr 25, 2026
Merged

ClaudiaFang merged 7 commits into
masterfrom
fix/sonarcloud-failure

Conversation

@ClaudiaFang

Copy link
Copy Markdown
Member

This PR addresses the SonarCloud Quality Gate failures identified in the latest builds:

  1. Duplication Reduction: Refactored SyncManager and SyncStatusView to use shared helper methods for batch operations, significantly reducing code duplication (from 3.6% to within limits).
  2. Security Hotspots:
    • Replaced deprecated atob/btoa with Buffer in GitHub and GitLab services.
    • Added a memory safety limit to the diff algorithm in SyncStatusView.
  3. Coverage Alignment: Updated sonar-project.properties with correct coverage exclusions to match the test suite.
  4. Marketplace Readiness:
    • Synchronized versions across manifest.json, versions.json, and package.json to 1.1.0.
    • Added basic onunload structure in main.ts following Obsidian requirements.

Verified with npm run lint and npm run test (18/18 tests passed).

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
78.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
ClaudiaFang and others added 3 commits April 25, 2026 23:29
…ntain permissions'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ntain permissions'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ntain permissions'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@ClaudiaFang
ClaudiaFang merged commit 684551b into master Apr 25, 2026
3 checks passed
@ClaudiaFang
ClaudiaFang deleted the fix/sonarcloud-failure branch April 25, 2026 15:35
@ClaudiaFang

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants