Skip to content

Fix lint - #15

Merged
ClaudiaFang merged 6 commits into
masterfrom
fix-lint
Apr 25, 2026
Merged

ClaudiaFang merged 6 commits into
masterfrom
fix-lint

Conversation

@ClaudiaFang

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase to improve modularity and consistency, notably by introducing a BaseGitService to centralize API logic and standardizing content encoding across services. It also refactors the SyncManager and SyncStatusView for better maintainability. However, several critical issues were identified: a regression in getFullPath that breaks absolute path bypassing, the use of blob_id instead of last_commit_id in GitLab services which will cause update failures, and missing rename detection logic in batch push operations.

Comment thread src/services/git-service-base.ts
Comment thread src/services/git-service-base.ts
Comment thread src/services/gitlab-service.ts Outdated
Comment thread src/logic/sync-manager.ts
- Add last_commit_id to GitLabFileResponse
- Use last_commit_id as sha in GitLabService.getFile
- Add rename detection to SyncManager.processSingleBatchPush
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
69.1% Coverage on New Code (required ≥ 80%)
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ClaudiaFang
ClaudiaFang merged commit 655cd69 into master Apr 25, 2026
16 of 18 checks passed
@ClaudiaFang
ClaudiaFang deleted the fix-lint branch April 25, 2026 21:23
@ClaudiaFang

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant