chore(ci): update minAppVersion to 1.12.7 and add git plugin to release - #18
Conversation
- Set manifest.json minAppVersion to 1.12.7 - Add @semantic-release/git plugin so release commits versions.json and other updated files back to the repository
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the minimum application version in manifest.json and configures the @semantic-release/git plugin in .releaserc.json to automate release commits. Feedback suggests including package-lock.json in the release assets to ensure it stays synchronized with package.json and shortening the release commit message by removing the full release notes to maintain a cleaner git history.
| [ | ||
| "@semantic-release/git", | ||
| { | ||
| "assets": ["manifest.json", "versions.json", "CHANGELOG.md", "package.json"], |
There was a problem hiding this comment.
When defining a custom assets list for the @semantic-release/git plugin, it overrides the default set. It is highly recommended to include package-lock.json (or your project's equivalent lockfile) to ensure it stays in sync with the version bump in package.json during releases. This prevents the repository from having an out-of-date lockfile after an automated release.
| "assets": ["manifest.json", "versions.json", "CHANGELOG.md", "package.json"], | |
| "assets": ["manifest.json", "versions.json", "CHANGELOG.md", "package.json", "package-lock.json"], |
| "@semantic-release/git", | ||
| { | ||
| "assets": ["manifest.json", "versions.json", "CHANGELOG.md", "package.json"], | ||
| "message": "chore(release): ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}" |
There was a problem hiding this comment.
Including ${nextRelease.notes} in the commit message can lead to extremely large messages, especially for releases with many changes. This can clutter the git history and occasionally cause issues with git hooks or platform limits. Since the full release notes are already captured in CHANGELOG.md and on the GitHub release page, a more concise message is generally preferred.
| "message": "chore(release): ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}" | |
| "message": "chore(release): ${nextRelease.version} [skip ci]" |
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
2 participants
other updated files back to the repository