ci: use shared obsidian plugin workflow and update obsidian version - #19
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the obsidian dependency to version 1.12.3 and adjusts the release configuration and version metadata. Feedback suggests removing the feature branch from the .releaserc.json to avoid accidental releases and aligning the minimum app version in versions.json with the dependency version specified in package-lock.json to ensure consistency.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "branches": ["main", "master"], | |||
| "branches": ["main", "master", "feat/use-shared-workflow"], | |||
There was a problem hiding this comment.
Including a specific feature branch (feat/use-shared-workflow) in the branches array will cause semantic-release to attempt a release from this branch. Typically, this configuration should only include stable branches (e.g., main, master) or designated pre-release branches. If this was added only for testing the CI changes, it should be removed before merging to avoid accidental releases or configuration clutter.
| "branches": ["main", "master", "feat/use-shared-workflow"], | |
| "branches": ["main", "master"], |
| @@ -1 +1 @@ | |||
| {"1.0.0": "0.15.0", "1.1.0": "0.15.0"} | |||
| {"1.0.0": "0.15.0", "1.1.0": "1.12.7"} | |||
There was a problem hiding this comment.
There is a version mismatch between the obsidian dependency (1.12.3 in package-lock.json) and the minAppVersion (1.12.7) specified here for version 1.1.0. This inconsistency may unnecessarily restrict users on Obsidian versions between 1.12.3 and 1.12.6. Unless 1.12.7 is specifically required for a bug fix or feature not present in 1.12.3, these versions should be aligned to ensure the widest possible compatibility for the targeted API version.
| {"1.0.0": "0.15.0", "1.1.0": "1.12.7"} | |
| {"1.0.0": "0.15.0", "1.1.0": "1.12.3"} |
|
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
1 participant
This PR simplifies the CI/CD pipeline by migrating to a shared GitHub Action workflow specifically designed for Obsidian plugins.
Changes:
.github/workflows/ci.ymlwithfirstsun-dev/general-workflows/.github/workflows/obsidian-plugin-ci.yml.obsidiandependency to1.12.3.versions.jsonto reflect the minimum Obsidian version requirement (1.12.7).feat/use-shared-workflowto.releaserc.jsonbranches.