fix: resolve obsidian community guidelines and lint errors - #7
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 3 commits
April 25, 2026 03:23
…removing duplicate lint workflow
ClaudiaFang
enabled auto-merge
April 25, 2026 04:17
ClaudiaFang
disabled auto-merge
April 25, 2026 04:22
ClaudiaFang
enabled auto-merge (squash)
April 25, 2026 04:22
|
Comment on lines
+12
to
+31
| name: Build | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '22' | ||
| cache: 'npm' | ||
| - run: npm ci | ||
| - run: npm run test -- --coverage | ||
| - run: npm run build | ||
|
|
||
| # Upload coverage for the next job | ||
| - name: Upload coverage | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: coverage-report | ||
| path: coverage/ | ||
|
|
||
| sonar: |
Comment on lines
+32
to
+47
| name: SonarQube | ||
| needs: build | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Download coverage | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: coverage-report | ||
| path: coverage/ | ||
| - name: SonarQube Scan | ||
| uses: SonarSource/sonarqube-scan-action@v7.1.0 | ||
| env: | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} |
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Member
Author
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Member
Author
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues identified by the Obsidian automated scan: