[pull] master from prestodb:master#570
Merged
pull[bot] merged 2 commits intofishbone:masterfrom Feb 17, 2026
Merged
Conversation
## Description, Motivation and Context The size estimate on text plans (EXPLAIN plans e.g) was incorrectly changed to use the plan root instead of the actual node's outputs in 7f5f219 We fix this bug ## Test Plan CI + new test to assert on `Estimates` strings in the text plan ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes ``` == NO RELEASE NOTE == ``` ## Summary by Sourcery Correct the size estimate used when rendering text query plans to rely on each node's own outputs instead of the plan root. Bug Fixes: - Fix incorrect output size estimation in TextRenderer by basing it on the node representation outputs rather than the plan root. Enhancements: - Expose a size-estimation helper on PlanNodeStatsEstimate that operates on NodeRepresentation outputs. ## Summary by Sourcery Correct size estimation used when rendering textual query plans so estimates are based on each node representation rather than the plan root. Bug Fixes: - Fix incorrect output size calculation in TextRenderer by using the node representation outputs instead of the plan root when computing size estimates. Enhancements: - Add a NodeRepresentation-based output size helper to PlanNodeStatsEstimate for reuse by plan printers and related components.
## Description Upgrades Apache Arrow dependencies to 18.3.0. ## Motivation and Context Using a more recent version helps avoid potential vulnerabilities and ensures we aren't relying on outdated or unsupported code. ## Impact Inherited connectors must use protobuf-java 4.30.x to avoid potential gencode issues. ## Test Plan Tested after upgrade and was able to connect to Flight server and fetch schemas <img width="1078" height="584" alt="Screenshot 2026-02-13 at 5 23 05 PM" src="https://github.com/user-attachments/assets/5b99131e-7644-4f77-b24a-ee53487f1e86" /> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == RELEASE NOTES == General Changes * Upgrade Apache Arrow to 18.3.0 and protobuf-java to 4.30.2. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )