Summary
cenc_decrypt.rs (lines 873–910) defines private copies of find_box, find_top_box, iter_child_boxes, iter_top_boxes, and descend — functionally identical to the pub(crate) find_top_box in media.rs:541 and the other box-nav helpers there.
Location
transmux/src/cenc_decrypt.rs:873-910 — private copies
transmux/src/media.rs:541+ — the canonical pub(crate) versions
Impact
Low. Code duplication, not a correctness bug. But any fix to the box iteration logic would need to be applied in both places.
Suggested fix
Remove the private copies in cenc_decrypt.rs and use the pub(crate) versions from media.rs (or a shared internal module).
Discovered by static analysis audit (transmux deep scan).
Summary
cenc_decrypt.rs(lines 873–910) defines private copies offind_box,find_top_box,iter_child_boxes,iter_top_boxes, anddescend— functionally identical to thepub(crate)find_top_boxinmedia.rs:541and the other box-nav helpers there.Location
transmux/src/cenc_decrypt.rs:873-910— private copiestransmux/src/media.rs:541+— the canonicalpub(crate)versionsImpact
Low. Code duplication, not a correctness bug. But any fix to the box iteration logic would need to be applied in both places.
Suggested fix
Remove the private copies in
cenc_decrypt.rsand use thepub(crate)versions frommedia.rs(or a shared internal module).Discovered by static analysis audit (transmux deep scan).